Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to DSL-based SpeziBluetooth #49

Merged
merged 21 commits into from
Feb 22, 2024
Merged

Upgrade to DSL-based SpeziBluetooth #49

merged 21 commits into from
Feb 22, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jan 22, 2024 •
edited
Loading

Upgrade to DSL-based SpeziBluetooth

♻️ Current situation & Problem

This PR upgrades to the latest Spezi 1.0 releases. Further, this upgrades to the upcoming SpeziBluetooth release that introduces a new and simplified DSL API for declaring Bluetooth devices.

⚙️ Release Notes

  • Upgrade to latest Spezi 1.0 releases
  • Upgrade to upcoming SpeziBluetooth releases.
  • Refactor the device model supporting three different devices types: Muse, Biopot, Mock.
  • Supporting auto connect and background auto connect with SpeziBluetooth backed devices (in our case the Biopot)
  • Added initial support for visionOS 🎉 (Note: visionOS builds currently don't include support for Questionnaires).
  • Added new "Detailed Headband Fit" view for Muse devices.
  • Improved discovery of Muse devices.

📚 Documentation

--

✅ Testing

Tests were adjusted and updated.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg mentioned this pull request Feb 10, 2024
Closed
1 task
@Supereg Supereg marked this pull request as ready for review February 10, 2024 08:08
@Supereg
Copy link
Member Author

Supereg commented Feb 11, 2024

@PSchmiedmayer seems like disabling the Password Auto Fill doesn't work (here/right now)? I did the same changes as in StanfordBDHG/.github#47 (e.g., enabling in the action, minor fast lane changes).
Seems like current PRs in the template app have a similar problem judging by their CI output (e.g., StanfordSpezi/SpeziTemplateApplication#68)?

@PSchmiedmayer
Copy link
Member

@Supereg Wanted to follow up on the password autofill issue; could we isolate this to a dedicated runner that causes this problem?

@Supereg
Copy link
Member Author

Supereg commented Feb 19, 2024

Didn't have the time to further investigate this issue right now.

@PSchmiedmayer
Copy link
Member

No worries; I will see what I can do this week 🚀

@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.55556% with 222 lines in your changes are missing coverage. Please review.

Project coverage is 84.25%. Comparing base (c448c04) to head (2fe1b42).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   82.50%   84.25%   +1.75%     
==========================================
  Files          84       94      +10     
  Lines        3114     3301     +187     
==========================================
+ Hits         2569     2781     +212     
+ Misses        545      520      -25
Files Coverage Δ
NAMS/Account/AccountButton.swift 100.00% <ø> (ø)
NAMS/Account/AccountSetupHeader.swift 100.00% <ø> (ø)
NAMS/Account/AccountSheet.swift 95.00% <ø> (ø)
NAMS/Devices/BatteryIcon.swift 86.67% <100.00%> (+7.36%) ⬆️
...s/Biopot/Characteristics/AccelerometerSample.swift 85.72% <100.00%> (ø)
...ices/Biopot/Characteristics/ByteBuffer+Int24.swift 80.44% <ø> (ø)
...vices/Biopot/Characteristics/DataAcquisition.swift 87.81% <100.00%> (ø)
...S/Devices/Biopot/Recording/EEGChannel+Biopot.swift 95.46% <ø> (ø)
NAMS/Devices/Biopot/Views/BiopotDeviceRow.swift 100.00% <100.00%> (ø)
NAMS/Devices/Mock/MockMeasurementGenerator.swift 58.14% <ø> (ø)
... and 66 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c448c04...2fe1b42. Read the comment docs.

@Supereg
Copy link
Member Author

Supereg commented Feb 19, 2024

Okay, the run just went through 🙃

@Supereg Supereg enabled auto-merge (squash) February 22, 2024 19:45
@Supereg Supereg disabled auto-merge February 22, 2024 20:23
@Supereg Supereg merged commit 1bf0808 into main Feb 22, 2024
9 checks passed
@Supereg Supereg deleted the feature/spezi-bluetooth-upgrade branch February 22, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Supereg @PSchmiedmayer